Add Maven wrapper for Jitpack builds.#2760
Conversation
jbonofre
left a comment
There was a problem hiding this comment.
ASF header is missing, and also the LICENSE/NOTICE should be updated as the source distribution include Maven resources.
|
@jbonofre Thank you for the quick reply. I'll fix this. Do you enable specific maven profiles when building karaf? |
|
Adding Jitpack support is blocked by |
|
@kenwenzel the CI is failure is due to a flaky test on Windows. I'm fixing that in a separate PR. |
|
@jbonofre I have two questions:
|
|
@kenwenzel I'm not against adding the mvn wrapper, but I don't think it's strictly required (we live without it for years 😄 ). |
|
@jbonofre I need a snapshot (or intermediate) build of Karaf and I thought it is possible via Jitpack. But Jitpack builds require a maven wrapper to work with recent maven versions. |
|
@kenwenzel alright, you have a new snapshot on the way and I'm fixing the weekly build to have up to date snapshots. |
Add Maven wrapper to execute Jitpack builds with Maven 3.9.0+.
Fixes #2759